Provide a direct means to observe changes in ApolloStore #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for apollo-ios-docc pending review.Visit the deploys page to approve it
|
👷 Deploy request for eclectic-pie-88a2ba pending review.Visit the deploys page to approve it
|
AnthonyMDev
requested changes
Mar 21, 2024
Apollo Kotlin currently provides a public API to get notified when objects in the ApolloStore are updated. iOS has a similar facility as well, but it has not been a public API. This change exposes the ApolloStoreSubscriber for public use. Refer: apollographql/apollo-ios#3350
jamesonwilliams
force-pushed
the
public-apollo-store-subscriber
branch
2 times, most recently
from
e31d708 to
f3f6f21
Compare
AnthonyMDev
approved these changes
Mar 22, 2024
jamesonwilliams
force-pushed
the
public-apollo-store-subscriber
branch
from
f3f6f21 to
6f66f7b
Compare
BobaFetters
pushed a commit
that referenced
this pull request
Mar 22, 2024
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Mar 22, 2024
BobaFetters
pushed a commit
that referenced
this pull request
Mar 22, 2024
3a70e655 Provide a direct means to observe changes in ApolloStore (#300) git-subtree-dir: apollo-ios git-subtree-split: 3a70e6557f1cd97879ee76dbe5b6f39c466f770e
BobaFetters
pushed a commit
that referenced
this pull request
Mar 22, 2024
…es in ApolloStore git-subtree-dir: apollo-ios git-subtree-mainline: 2b6b61b git-subtree-split: 3a70e6557f1cd97879ee76dbe5b6f39c466f770e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Full context in apollographql/apollo-ios#3350.)
Apollo Kotlin currently provides a public
changedKeysproperty to get notified when objects in the ApolloStore change. Internally, iOS has had a similar facility, too -- but it hasn't beenpublicuntil now.