Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some docs #5

Merged
merged 3 commits into from
Jan 14, 2024
Merged

add some docs #5

merged 3 commits into from
Jan 14, 2024

Conversation

jcorcoran
Copy link
Contributor

@jcorcoran jcorcoran commented Jan 14, 2024 •
edited
Loading

  • added notional subsystem descriptions
  • update photonlib vendordep to fix build error (old version removed from their server)
  • add issue & mr templates from 2023 repo

@jcorcoran jcorcoran changed the title add comse notional subsystems add some docs Jan 14, 2024
@jcorcoran jcorcoran requested a review from gordonbchen January 14, 2024 16:40
gordonbchen
gordonbchen approved these changes Jan 14, 2024
View reviewed changes
Copy link
Contributor

@gordonbchen gordonbchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gordonbchen gordonbchen linked an issue Jan 14, 2024 that may be closed by this pull request
Set up CI + branch protection rules #3
Closed
@gordonbchen gordonbchen merged commit b209602 into main Jan 14, 2024
1 check passed
@gordonbchen gordonbchen deleted the jmc_subsystem_docs branch January 14, 2024 17:01
@gordonbchen gordonbchen removed a link to an issue Jan 14, 2024
Set up CI + branch protection rules #3
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gordonbchen gordonbchen gordonbchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcorcoran @gordonbchen