Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support spatial velocity gradient input for crystal models #187

Merged
merged 12 commits into from
Jan 2, 2025
Merged

Support spatial velocity gradient input for crystal models #187

merged 12 commits into from
Jan 2, 2025

Conversation

reverendbedford
Copy link
Collaborator

Add some trivial models and tensor types for splitting an R2 into symmetric and skew parts.

Test a crystal model taking the spatial velocity gradient as input.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

Documentation preview removed.
To view the documentation, please visit the main documentation page.

hugary1995
hugary1995 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@hugary1995 hugary1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Feel free to merge after addressing the minor comments.

include/neml2/models/R2toSR2.h Outdated Show resolved Hide resolved
include/neml2/models/R2toWR2.h Outdated Show resolved Hide resolved
src/neml2/models/R2toWR2.cxx Outdated Show resolved Hide resolved
@reverendbedford
Copy link
Collaborator Author

Don't merge yet, still want to test in MOOSE.

@reverendbedford reverendbedford force-pushed the spatial_velocity_input branch 3 times, most recently from 633ba95 to 66be1fe Compare December 19, 2024 20:38
hugary1995
hugary1995 requested changes Dec 20, 2024
View reviewed changes
CMakePresets.json Outdated Show resolved Hide resolved
include/neml2/models/IncrementalRate.h Outdated Show resolved Hide resolved
src/neml2/models/IncrementalRate.cxx Outdated Show resolved Hide resolved
src/neml2/models/IncrementalRate.cxx Outdated Show resolved Hide resolved
src/neml2/models/IncrementalRate.cxx Outdated Show resolved Hide resolved
src/neml2/models/IncrementalRate.cxx Outdated Show resolved Hide resolved
python/examples/statistical.ipynb Outdated Show resolved Hide resolved
python/neml2/pyzag/interface.py Show resolved Hide resolved
This was referenced Dec 21, 2024
Closed
Merged
Merged
@hugary1995 hugary1995 force-pushed the spatial_velocity_input branch 3 times, most recently from 43b29ae to c5080e0 Compare January 2, 2025 09:31
hugary1995
hugary1995 approved these changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@hugary1995 hugary1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix one typo then good to go.

src/neml2/models/R2toWR2.cxx Outdated Show resolved Hide resolved
@reverendbedford reverendbedford merged commit 789bdbe into main Jan 2, 2025
23 checks passed
@reverendbedford reverendbedford deleted the spatial_velocity_input branch January 2, 2025 18:16
github-actions bot added a commit that referenced this pull request Jan 2, 2025
@github-actions
Remove preview for PR #187
3de9ba2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugary1995 hugary1995 hugary1995 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reverendbedford @hugary1995