Refactor to consolidate async dbt adapter code #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sunny-pastelito-5ecb04 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying astronomer-cosmos with
|
| Latest commit: |
9b88931
|
| Status: | ⚡️ Build in progress... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
=======================================
Coverage 97.33% 97.33%
=======================================
Files 80 79 -1
Lines 4691 4696 +5
=======================================
+ Hits 4566 4571 +5
Misses 125 125 ☔ View full report in Codecov by Sentry. |
dosubot
bot
added
size:L
tatiana
reviewed
Feb 6, 2025
tatiana
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Looks great, @pankajkoti , thank you very much for refactoring this part of the code. I left a minor feedback on the helper.py module name
pankajkoti
force-pushed
the
refactor-bq-adapter-methods
branch
from
036b214 to
9b88931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the feedback in PR #1474 suggesting to consolidate dbt adapter methods
in the _asynchronous module and additionally avoiding keeping dictionary type maps for adapter
callables.
closes: #1508