-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move redundant dependency information to workspace Cargo.toml #3411
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks!
parity-scale-codec = { workspace = true, features = ["derive"] } | ||
domain-runtime-primitives.workspace = true | ||
frame-benchmarking = { workspace = true, optional = true } | ||
frame-support.workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: would have preferred
frame-support = {workspace = true}
for consistency but not a blocker
This PR unifies all dependency specifiers in
subspace/Cargo.toml
, rather than repeating the same base dependency information across 75+ crates.Some information can not be unified:
To get more dependencies to unify, this PR also:
thiserror
dependency from 1.0.64 to 2.0.0After the automated unification using
cargo autoinherit
, some fixes are needed:Close #3397
Code contributor checklist: