-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autoware_control_center and autoware_node #84
base: main
Are you sure you want to change the base?
Conversation
@xmfcx I found this about using Kubernetes to ensure a singleton instance: https://medium.com/@fahed.dorgaa/kubernetes-singleton-pattern-84a88a06727a And this for integrating Kubernetes with ROS 2: https://github.com/fujitatomoya/ros_k8s Hope this helps, let me know if I can help |
@esteve I've read the medium post and it aims to solve the same problem I had. I've also read the slides and looked into implementations from https://github.com/fujitatomoya/ros_k8s as well.
But k8s works with containers and I would assume this would have meant that I think current solution is enough for now, since in the deployment stage, this would not occur anyways, it is just to prevent adding another thing to debug for developers by making sure there is only one instance of the |
@xmfcx yeah, for something like this,, Kubernetes is overkill, I thought it was more about making sure that nodes in a distributed system were only instantiated only. But if it's a tool that runs locally, a lock and a file is more than enough. |
7628800
to
a1b7090
Compare
a1b7090
to
dc0fb55
Compare
This pull request has been automatically marked as stale because it has not had recent activity. |
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
1c2748f
to
185343f
Compare
Description
Goals for the v1:
Remaining tasks
Edge cases
Support:
Related links
🖱️Click to expand
Continuation from:
feat: add autoware_node and autoware_control_center #73
https://github.com/orgs/autowarefoundation/discussions/3194
Nav2 references
Autoware.Auto discussions
Tests performed
WIP
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.