Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(route_selector): add processing time publisher #9343

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Kazunori-Nakajima
Copy link
Contributor

@Kazunori-Nakajima Kazunori-Nakajima commented Nov 18, 2024

Description

The processing time of route_selector was measured and made to Pub.
Since A is not a module that is processed cyclically, Pub was added to the following four functions that may become heavy processing.

  • on_set_waypoint_route_main
  • on_set_lanelet_route_main
  • on_set_waypoint_route_mrm
  • on_set_lanelet_route_mrm

(TIER IV internal usecase)
This output is then read by the Basic scenario and tested daily for cycle failures.

Related links

How was this PR tested?

  1. Place Ego and goal_pose in psim and generate route
  2. ros2 topic echo /planning/mission_planning/route autoware_planning_msgs/msg/LaneletRoute > routefile
  3. Delete start_pose and --- on the last line of the routefile
  4. ros2 service call /planning/mission_planning/route_selector/mrm/set_lanelet_route tier4_planning_msgs/srv/SetLaneletRoute "$(cat routefile)"

Screenshot from 2024-11-18 08-49-13

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 29.19%. Comparing base (8652963) to head (32745b0).
Report is 52 commits behind head on main.

Files with missing lines Patch % Lines
...ion_planner/src/mission_planner/route_selector.cpp 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9343      +/-   ##
==========================================
- Coverage   29.21%   29.19%   -0.03%     
==========================================
  Files        1335     1342       +7     
  Lines      102960   103042      +82     
  Branches    39950    39953       +3     
==========================================
  Hits        30080    30080              
- Misses      70010    70092      +82     
  Partials     2870     2870              
Flag Coverage Δ *Carryforward flag
differential 10.01% <0.00%> (?)
total 29.21% <ø> (ø) Carriedforward from 8652963

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service callback functions of this node may abort due to exceptions. In that case, the processing time will not be published, will this be OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants