Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_system_rviz_plugin): add parameter of max_line_text_num #9370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Nov 19, 2024

Description

inserted a new line in the MRM summary rviz plugin so that the text does not cover other visualization

before
(See the upper left text)
image

after
image

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Nov 19, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168
Copy link
Contributor Author

@kminoda
レビューよろしくお願いします

@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 29.65%. Comparing base (b4603fd) to head (1380f79).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
...em_rviz_plugin/src/mrm_summary_overlay_display.cpp 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9370      +/-   ##
==========================================
- Coverage   29.66%   29.65%   -0.01%     
==========================================
  Files        1338     1338              
  Lines      103204   103214      +10     
  Branches    40216    40219       +3     
==========================================
  Hits        30611    30611              
- Misses      69638    69648      +10     
  Partials     2955     2955              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.66% <ø> (+<0.01%) ⬆️ Carriedforward from b4603fd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants