Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): tuner: prefer ncclInvalidArgument #359

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix(build): tuner: prefer ncclInvalidArgument #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/tuner/nccl_ofi_tuner.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,12 @@ ncclResult_t nccl_ofi_tuner_init(size_t nRanks, size_t nNodes, ncclDebugLogger_t
*/
if (getenv("NCCL_ALGO") || getenv("NCCL_PROTO")) {
NCCL_OFI_WARN("The tuner plugin can not be loaded when explicitly choosing an algorithm or protocol with NCCL_ALGO/NCCL_PROTO");
return ncclInvalidUsage;
// FIXME: "ncclInvalidUsage should be returned when the error is
// most likely a user error" per nccl docs, which arguably makes
// it a better return code here than ncclInvalidArgument, but
// the former is currently not vended in ext-net headers, so
// we're returning ncclInvalidArgument instead.
return ncclInvalidArgument;
}

struct nccl_ofi_tuner_model_params params = {
Expand Down
Loading