fix(build): tuner: prefer ncclInvalidArgument #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
AvivBenchorin
added
BuildTriggerRequest
rajachan
reviewed
Mar 13, 2024
bwbarrett
previously approved these changes
Mar 14, 2024
ncclInvalidArgument is present both in neuron and nvidia whereas ncclInvalidUsage is only present in neuron headers. Callsite just wraps the value in ncclcheck and the meaning isn't meaningfully changed, so prefer the portable one.
ghost
force-pushed
the
tuner-retcode-change
branch
from
af2f4ca to
d127fa8
Compare
rajachan
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ncclInvalidArgument is present both in neuron and nvidia whereas ncclInvalidUsage is only present in neuron headers. Callsite just wraps the value in ncclcheck and the meaning isn't meaningfully changed, so prefer the portable one.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.