Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source uri to headers for COPY request #1228

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Add source uri to headers for COPY request #1228

merged 7 commits into from
Jan 16, 2025

Conversation

IsaevIlya
Copy link
Contributor

This changes is to address gap in supporting buckets with dots in the name for COPY requests.
First encountered in s3-torch-connector awslabs/s3-connector-for-pytorch#295

Does this change impact existing behavior?

No

Does this change need a changelog entry?

Yes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@IsaevIlya IsaevIlya added the CRT dependency requires CRT work label Jan 14, 2025
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 14, 2025 10:18 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 14, 2025 10:18 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 14, 2025 10:18 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 14, 2025 10:18 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 14, 2025 10:18 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 14, 2025 10:18 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 14, 2025 10:18 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a review from passaro January 14, 2025 10:18
@IsaevIlya IsaevIlya marked this pull request as draft January 14, 2025 10:19
@passaro passaro mentioned this pull request Jan 14, 2025
Merged
@IsaevIlya IsaevIlya force-pushed the feature/support-copy-dot-bucker branch from a1f50ad to a595511 Compare January 15, 2025 13:33
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:34 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:34 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:34 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:34 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:34 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:34 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:34 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya force-pushed the feature/support-copy-dot-bucker branch from a595511 to ab8a3fb Compare January 15, 2025 13:35
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:35 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:35 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:36 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:36 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:36 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:36 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 13:36 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya marked this pull request as ready for review January 15, 2025 13:37
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 14:28 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 15, 2025 14:28 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya force-pushed the feature/support-copy-dot-bucker branch from de4156a to 9c1b3d5 Compare January 15, 2025 16:45
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 15, 2025 16:45 — with GitHub Actions Inactive
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 15, 2025 16:45 — with GitHub Actions Inactive
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 15, 2025 16:45 — with GitHub Actions Inactive
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 15, 2025 16:45 — with GitHub Actions Inactive
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 15, 2025 16:45 — with GitHub Actions Inactive
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 15, 2025 16:45 — with GitHub Actions Inactive
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 15, 2025 16:45 — with GitHub Actions Inactive
passaro
passaro reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@passaro passaro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of minor nits.

EDIT: It also needs an entry in the changelog.

mountpoint-s3-client/src/s3_crt_client/copy_object.rs Outdated Show resolved Hide resolved
mountpoint-s3-crt/src/s3/client.rs Outdated Show resolved Hide resolved
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 16, 2025 10:17 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 16, 2025 10:17 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 16, 2025 10:17 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 16, 2025 10:17 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 16, 2025 10:17 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 16, 2025 10:17 — with GitHub Actions Waiting
@IsaevIlya IsaevIlya requested a deployment to PR integration tests January 16, 2025 10:17 — with GitHub Actions Waiting
@IsaevIlya @passaro
Update mountpoint-s3-client/CHANGELOG.md
4441200 
Co-authored-by: Alessandro Passaro <[email protected]>
Signed-off-by: Isaev Ilya <[email protected]>
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 16, 2025 11:27 — with GitHub Actions Inactive
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 16, 2025 11:27 — with GitHub Actions Inactive
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 16, 2025 11:27 — with GitHub Actions Inactive
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 16, 2025 11:27 — with GitHub Actions Inactive
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 16, 2025 11:27 — with GitHub Actions Inactive
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 16, 2025 11:27 — with GitHub Actions Inactive
@IsaevIlya IsaevIlya temporarily deployed to PR integration tests January 16, 2025 11:27 — with GitHub Actions Inactive
passaro
passaro approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@passaro passaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@passaro passaro added this pull request to the merge queue Jan 16, 2025
Merged via the queue into awslabs:main with commit ace3093 Jan 16, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@passaro passaro passaro approved these changes

Assignees
No one assigned
Labels
CRT dependency requires CRT work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IsaevIlya @passaro