Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source uri to headers for COPY request #1228

Merged
merged 7 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mountpoint-s3-client/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@

### Other changes

* Copy object operation now support buckets with dots in the name by including extra header with source uri
([#1228](https://github.com/awslabs/mountpoint-s3/pull/1228)).
Support on CRT side was introduced in [awslabs/aws-c-s3/482](https://github.com/awslabs/aws-c-s3/pull/482)
IsaevIlya marked this conversation as resolved.
Show resolved Hide resolved
* `HeadObjectResult` now includes the server-side encryption settings used when storing the object.
([#1143](https://github.com/awslabs/mountpoint-s3/pull/1143))
* Add parameter to request checksum information as part of a `HeadObject` request.
Expand Down
2 changes: 1 addition & 1 deletion mountpoint-s3-client/src/s3_crt_client/copy_object.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ use std::ops::Deref;
use std::os::unix::prelude::OsStrExt;

use mountpoint_s3_crt::{http::request_response::Header, s3::client::MetaRequestResult};
use tracing::trace;

use crate::object_client::{CopyObjectError, CopyObjectParams, CopyObjectResult, ObjectClientResult};
use crate::s3_crt_client::{S3CrtClient, S3CrtClientInner, S3Operation, S3RequestError};
use tracing::trace;

impl S3CrtClient {
/// Create and begin a new CopyObject request.
Expand Down
2 changes: 1 addition & 1 deletion mountpoint-s3-crt/src/s3/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -323,13 +323,13 @@ impl<'a> MetaRequestOptions<'a> {
endpoint: None,
signing_config: None,
checksum_config: None,
copy_source_uri: None,
on_telemetry: None,
on_headers: None,
on_body: None,
on_upload_review: None,
on_finish: None,
_pinned: Default::default(),
copy_source_uri: None,
});

// Pin the options in-place. This is because it's about to become self-referential.
Expand Down
Loading