fix: accumulate image manifests in oci_image_index #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
approved these changes
Jun 20, 2024
|
would be nice to have a test for this. |
seh
force-pushed
the
correct-oci-image-index-manifest-collection
branch
from
b757fb3 to
d96429a
Compare
It turns out that we did, sort of, in the sense that it sets up the right scenario. It was confirming the message digest of the index—one that had contained the wrong set of manifests—but it does not yet check, say, the number of manifests present in the index. |
|
It appears that the lone CI workflow failure was due to a flaky server. I lack permission to run the workflow again. Can one of the maintainers please trigger that workflow to run again? |
seh
commented
Jun 24, 2024
In the recent bazel-contrib#386, when we replaced use of the "yq" tool with the "jq" tool, we translated the "oci_image_index" rule's accumulation of image manifests incorrectly, such that we lose all but the last index that we add to the index. In "jq", the "update-assignment" operator (|=) does not append to an array supplied as its left-hand context value automatically. Instead, one must use a "complex assignment", mentioning the context value explicitly together with the addition operator.
seh
force-pushed
the
correct-oci-image-index-manifest-collection
branch
from
d96429a to
c3ff469
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the recent #386, when we replaced use of the yq tool with the jq tool, we translated the
oci_image_indexrule's accumulation of image manifests incorrectly, such that we lose all but the last index that we add to the index.In
jq, the update-assignment operator (|=) does not append to an array supplied as its left-hand context value automatically. Instead, one must use a complex assignment, mentioning the context value explicitly together with the addition operator.See the preceding discussion in the "docker" channel of the "Bazel" Slack workspace a chronicle of discovering this defect.
Fixes #638.