fix oci image index script #637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script does not work for multiarch images as it does not append to the manifests. Instead it replaces with the latest one which results in the last architecture to be the only one supported. JQ has an option to append an element to an array. Signed-off-by: Tobias Kohlbau <[email protected]>
|
We at @myopenfactory deployed these changes into our monorepo and confirmed that it works like the 1.x versions of rules_oci. |
|
This is a duplicate of #633. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script does not work for multiarch images as it does not append to the manifests. Instead it replaces with the latest one which results in the last architecture to be the only one supported. JQ has an option to append an element to an array.
Fixes #638