Declare dependencies in vendored crates #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matts1
force-pushed
the
declare
branch
4 times, most recently
from
064306c to
41030ae
Compare
|
Do you wanna update the examples in a separate PR as well to reduce the noise? |
tbaing
approved these changes
Nov 10, 2023
|
@UebelAndre I can do so if you prefer, but I'm personally fine with it as is. Also, do you mean just the |
|
Just the missed examples. it would be good to keep this PR limited to only the changes made here. So yeah, anything that needs to be regenerated and includes additional stuff should be a separate change |
|
Ok, I just rebased, diffs look much cleaner now |
UebelAndre
requested changes
Nov 17, 2023
|
@matts1 I think this is good to go pending a rebase |
This is required for bzlmod to vendor repos (https://docs.google.com/document/d/1dj8SN5L6nwhNOufNqjBhYkk5f-BJI_FPYWKxlB3GAmA/edit#heading=h.5mcn15i0e1ch) Change-Id: I00677170b37ab49f1eb5aefd701900371ed8ce24
Change-Id: Ic43373e989807503b4b68c96d9918bffcefa2880
|
@UebelAndre Fixed the merge conflicts by rebasing and rerunning vendor. |
Change-Id: I0047f977b0481a470e95d05d491ad6b52718b279
UebelAndre
approved these changes
Dec 4, 2023
illicitonion
pushed a commit
that referenced
this pull request
Dec 12, 2023
See #2246 for how we declare dependencies automatically for third party crates. I'm using the same mechanism for all other repositories. Note that the MODULE.bazel changes in use_repo are autogenerated, and if you change the third party crates you depend on, you should get an error message saying something like "run this command to fix it" on your bzlmod presubmit environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you run
bazel build --enable_bzlmod //crate_universe:bin, you get the errorundefined repo @cui.When you add a dependency on CUI, you get errors like
undefined repo @cui__<crate>-<version>(the repo for the third party crate).This change will allow us to automatically declare dependencies on our third party crates from bzlmod (see https://docs.google.com/document/d/1dj8SN5L6nwhNOufNqjBhYkk5f-BJI_FPYWKxlB3GAmA/edit#heading=h.5mcn15i0e1ch).