Allow additional targets to compile with bzlmod #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matts1
force-pushed
the
use_repo
branch
2 times, most recently
from
b32196f to
54bd04a
Compare
Change-Id: I5d843f6b660731a35c6c4205b7d8c91b46716815
matts1
force-pushed
the
use_repo
branch
2 times, most recently
from
46e291d to
e786844
Compare
illicitonion
approved these changes
Dec 11, 2023
|
Build appears to be failing because of the upgrade to bazel 7.0.0. I created an empty PR that's failing these same presubmits (#2316) |
|
Filed #2317 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2246 for how we declare dependencies automatically for third party crates. I'm using the same mechanism for all other repositories.
Note that the MODULE.bazel changes in use_repo are autogenerated, and if you change the third party crates you depend on, you should get an error message saying something like "run this command to fix it" on your bzlmod presubmit environment.