-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid to export Debug flags #121
Avoid to export Debug flags #121
Conversation
I'm not an expert on building software. In my mind there are three use-cases which need to work somehow:
What exactly is needed to make these work is unclear to me. Also, that is almost certainly an oversimplified view of the world. In any case, I don't think getting it together is a per project chouce alone. It may be reasonable to discuss that on Discourse (maybe there is already such a discussion). |
The problems may ocure when the project ist used with FetchContent: if the user want only build it project, that needs a build dependency to
But if the user want to install its own packackage, it will be complicated!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This in the direction of what I imagine. For my normal process I'd want to test but disable the find-package-test
as it takes a while. I think I'll need three small changes to also accomplish that (I can create a PR for these):
-
Define another option
BEMAN_EXECUTION26_ENABLE_FINDPACKAGE_TESTING
unconditionally defaulting toON
. -
Add this option as another condition before adding the
find-package-test
. -
Add something to the
Makefile
, e.g., using a variableEXTRA_CMAKE_OPTIONS
, which can be set when invoking make to pass it on:EXTRA_CMAKE_OPTIONS="-DBEMAN_EXECUTION26_ENABLE_FINDPACKAGE_TESTING=OFF" make
... or setting an environment variable. This way it is possible to selectively disable the test which runs long without modifying the files checked in. I'll create a corresponding PR (although I plan to change the repository name, namespace, etc. from execution26
to execution
, following the recent decision on repository names, first).
* Avoid to export Debug flags * Fix typo and add more options
sanitizer
on ALL supportedhosts
with ALL supportedcompilers
with ALL supported c++ std!Release
without developer settings on CIcmake config package
can be found and used