-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clipping rects in ui_layout_system
#16732
Open
ickshonpe
wants to merge
13
commits into
bevyengine:main
Choose a base branch
from
ickshonpe:clip-in-layout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+114
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed `update_clipping_system` and renamed the module to `update_target_cameras`.
…n for hidden nodes.
I'll do some benchmarks a bit later this evening. Typically it seems to only be a ~10% improvement overall but something like a modal UI with a very deep tree that uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Performance
A change motivated by improving speed, memory usage or compile times
D-Modest
A "normal" level of difficulty; suitable for simple features or challenging fixes
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Perform UI clipping updates during the walk to update the rest of the layout properties.
Solution
update_clipping_system
and renamed theupdate
module toupdate_target_cameras
.update_clipping_systems
to theupdate_uinode_geometry_recursive
function in thelayout
module.Display::None
set and their descendants don't need a full update, so added a second function tolayout
calledhide_uinodes_recursive
that just walks down the tree and sets the node sizes to zero.Results
Yellow is this PR, red is main.
The layout for
many_buttons
is very shallow and I'd expect most Bevy UI apps will see larger improvements in layout performance (but at the same time they'll have probably use less nodes so the absolute gains will be smaller).