Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence deprecation warning in Bundle derive macro (#17369) #17790

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Silence deprecation warning in Bundle derive macro (#17369) #17790

merged 1 commit into from
Feb 11, 2025

Conversation

Person-93
Copy link
Contributor

Objective

Solution

  • Add #[allow(deprecated)] to the generated code.

@github-actions GitHub Actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

alice-i-cecile
alice-i-cecile reviewed Feb 11, 2025
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah interesting, apparently the expect wasn't needed. I'm still a bit ehh about this idea in general: I think it masks real problems to ease one-time migration pain.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use X-Controversial There is active debate or serious implications around merging this PR labels Feb 11, 2025
@Person-93
Copy link
Contributor Author

I'm still a bit ehh about this idea in general: I think it masks real problems to ease one-time migration pain.

Can you elaborate? What problems does this mask?

@alice-i-cecile
Copy link
Member

Hmm, no I think I was wrong. This is only for the Bundle code gen, which isn't a particularly useful case to warn about.

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed X-Controversial There is active debate or serious implications around merging this PR labels Feb 11, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 11, 2025
Merged via the queue into bevyengine:main with commit 575f665 Feb 11, 2025
35 checks passed
@Person-93 Person-93 deleted the fix-spurious-deprecated-warnings branch February 11, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated bundles cause compiler warnings
2 participants
@Person-93 @alice-i-cecile