-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel Transform Propagation #17840
base: main
Are you sure you want to change the base?
Conversation
Getting this up now that it seems to function, marking as draft because it still needs cleanup. |
FYI, I'm merging #17815. The methods there are probably worth benching here. |
I'd love a before / after tracy histogram BTW. I've seen enough tests on Discord to be convinced that this is markedly (3x or so) faster, but it would be lovely to show in the release notes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks complicated at first glance, but it's actually not so bad, especially because of the comments on all the non-obvious stuff. Awesome improvements! Thanks for your efforts. And I'm glad we have unit tests for this. :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Overall makes sense to me, but I'm going to give this another pass tomorrow and try and understand the logic a little better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just had a few questions. Overall thanks a ton for doing this work, it really helps!
Objective
Solution
Testing