feat(playground): remove import sorting tab, rename import sorting to assist, add rule domains #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dyc3
changed the title
dyc3
force-pushed
the
playground-next-features
branch
2 times, most recently
from
cf81809 to
caa3beb
Compare
dyc3
force-pushed
the
playground-next-features
branch
2 times, most recently
from
9bfa5db to
3da4b3d
Compare
dyc3
changed the title
|
Not sure what happened, but the Assist tab isn't visible from mobile |
|
All analyzer fixes are emitted in the |
dyc3
force-pushed
the
playground-next-features
branch
from
3da4b3d to
effd931
Compare
dyc3
force-pushed
the
playground-next-features
branch
2 times, most recently
from
97d3914 to
df9b698
Compare
dyc3
force-pushed
the
playground-next-features
branch
from
df9b698 to
bc156a5
Compare
|
I've fixed it so that rule domain settings end up in saved in and loaded from the url, among other obvious things. Should be ready to merge. |
|
There's a small bug I found, but it's not related to this PR. On mobile, the tab settings doesn't scroll |
ematipico
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fully removes the import sorting tab and makes the UI changes necessary to show "Assist" instead of "Import sorting".
It also adds UI for being able to specify rule domains. I'm not entirely sure what to do with the
Lint Rulesoption though. Open to suggestions.Caution
This PR is stacked on the following PRs. Do not merge it without merging the others and rebasing this branch. To review this PR, look at the last commit only.