Poetry build #152
Poetry build #152
Conversation
This reverts commit ad8ba82.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #152 +/- ##
=======================================
Coverage 90.87% 90.87%
=======================================
Files 89 89
Lines 9607 9610 +3
=======================================
+ Hits 8730 8733 +3
Misses 877 877
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Nice! curl-ing to get Poetry is definitely the best way to get poetry in a workflow environment.
There was a problem hiding this comment.
there was a broken set of dependencies in python 3.11 (rbapy failed in 3.11).
There was a problem hiding this comment.
I enjoy whenever we get to use the Docker python API!
There was a problem hiding this comment.
This is fine, I just wonder if the strictness of python = "~3.10" will jam things up in envs that use 3.11 or 3.12, etc. Just something to keep in mind! This might be a very picky comment!
What new features does this PR implement?
resolve build dependencies and switch to poetry package manager and pyproject.toml instead of requirements.txt and setup.py. Requires Python 3.10.
How have you tested this PR?
integrated with biosimulators_test_suite prior to merge.
Additional information
deployment to PyPI with new pyproject.toml project definition not yet tested.