fix: reload crashes the app #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhancock
reviewed
Feb 5, 2025
ui/desktop/src/main.ts
Outdated
| }) | ||
| .catch((err) => { | ||
| console.error('Failed to load window:', err); | ||
| // Try alternative path if first attempt fails |
There was a problem hiding this comment.
Is this alternative more likely to work? If so, should we just use it as the only way we try to load the index.html? Feels like we should be able to know one that will work and use it.
There was a problem hiding this comment.
fair! let me do a rev on this
There was a problem hiding this comment.
you were right - not needed. reload continues to work.
nahiyankhan
force-pushed
the
nahiyan/reload-crash
branch
from
3db1b84 to
11a0cc7
Compare
|
Closes #881 |
lily-de
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reloads are crashing the app because it loses context on how to access the routes to load.
The fix appears is to use proper file protocol URL with correct base path in production.