[Feat] User 검색 API 구현 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iam454
approved these changes
Nov 27, 2024
jjeonghak
approved these changes
Nov 27, 2024
PMtHk
approved these changes
Nov 27, 2024
| async searchUsers(query: string) { | ||
| return this.userRepository.find({ | ||
| where: { | ||
| username: Like(`${query}%`), |
There was a problem hiding this comment.
🟡
PMtHk 인데, Hk 로 검색하면 동작하지 않을 것 같습니다.
의도하신 부분일까요?
There was a problem hiding this comment.
넵 무조건 앞 부분 기준으로만 검색되게 했습니다 !
Like %{query}% 는 인덱스 적용이 잘 안되는 것으로 알고 있어서, 사용자 경험을 크게 저해하지 않는다면 이렇게 구현해도 괜찮다고 생각했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈 번호
close #174
작업 내용
고민과 학습내용