Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] User 검색 API 구현 #175

Merged
merged 1 commit into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/server/src/account/account.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,11 @@ import { RefreshTokenGuard } from '@/account/guard/refreshToken.guard';
import { AuthService } from '@/account/auth.service';
import { Account } from '@/account/entity/account.entity';
import { UserService } from './user.service';
import { UserController } from './user.controller';

@Module({
imports: [JwtModule.register({ global: true }), TypeOrmModule.forFeature([Account])],
controllers: [AuthController],
controllers: [AuthController, UserController],
providers: [
AuthService,
UserService,
Expand Down
14 changes: 14 additions & 0 deletions apps/server/src/account/user.controller.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import { Controller, Get, Query } from '@nestjs/common';
import { UserService } from './user.service';
import { ResponseMessage } from '@/common/decorator/response-message.decorator';

@Controller('user')
export class UserController {
constructor(private readonly userService: UserService) {}

@Get()
@ResponseMessage('유저 정보가 성공적으로 조회되었습니다.')
async searchUsers(@Query('search') query: string) {
return this.userService.searchUsers(query);
}
}
11 changes: 10 additions & 1 deletion apps/server/src/account/user.service.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Injectable } from '@nestjs/common';
import { Repository } from 'typeorm';
import { Like, Repository } from 'typeorm';
import { InjectRepository } from '@nestjs/typeorm';
import { Account } from './entity/account.entity';

Expand All @@ -16,4 +16,13 @@ export class UserService {
user.profileImage = profileImage;
return this.userRepository.save(user);
}

async searchUsers(query: string) {
return this.userRepository.find({
where: {
username: Like(`${query}%`),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡
PMtHk 인데, Hk 로 검색하면 동작하지 않을 것 같습니다.
의도하신 부분일까요?

Copy link
Collaborator Author

@yangchef1 yangchef1 Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 무조건 앞 부분 기준으로만 검색되게 했습니다 !
Like %{query}% 는 인덱스 적용이 잘 안되는 것으로 알고 있어서, 사용자 경험을 크게 저해하지 않는다면 이렇게 구현해도 괜찮다고 생각했습니다.

},
select: ['id', 'username', 'profileImage'],
});
}
}