This repository has been archived by the owner on Dec 17, 2018. It is now read-only.
Change plugin logic to work with VTT files #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkjanm
commented
Mar 20, 2015
dirkjanm
commented
- Changed plugin to work with VTT files as a metadata track on the player as discussed in Sponsor WebVTT support #22
- Added example VTT file and image
- Support for mediafragments in VTT files
- Width/height fallback in case the width/height is not specified in the VTT file
- Updated documentation
- Bumped version
| halfWidth = width / 2; | ||
|
|
||
| // make sure that the thumbnail doesn't fall off the right side of the left side of the player | ||
| if ( (left + halfWidth) > right ) { | ||
| left -= (left + halfWidth) - right; | ||
| left = right - width; |
There was a problem hiding this comment.
Both of the edge cases are much cleaner. Nice!
|
This looks really great! I only have one comment, and it's definitely a nitpick. In the rest of the Brightcove video.js plugins, we try to be consistent about putting whitespace around operators and including the optional curly-braces for single-line |
|
@dmlap I think this should take care of them all. |
|
@dmlap Any update on this? |
|
? |
|
just reminding @dmlap that this one is still open |
|
Seems this is not working for me with videojs v5.4.6, I'm not sure what problem happened, can you fix it and update your demo work? thanks lot! |
External Source thumbnail from other domain
|
is it going to be merged or what? @dmlap |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.