This repository has been archived by the owner on Dec 17, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 95
Change plugin logic to work with VTT files #27
Open
dirkjanm
wants to merge
11
commits into
brightcove:master
Choose a base branch
from
dirkjanm:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
cb002ee
Changed plugin to work exclusively with VTT metadata files
dirkjanm fda84a5
Added sample files
dirkjanm db1f288
Add back travis badge, bump version and clean gitignore for PR
dirkjanm f61523e
Fix mistake with absolute links in VTT example file
dirkjanm 922dd22
Formatting and whitespace fixes
dirkjanm 707864c
Fixed some issues with multiline sprited images not displaying correctly
dirkjanm 9f4b4c5
Exception track metadata does not exist
creativefull 14c239b
add path thumbnail
creativefull c74acce
How to Add Path Thumbnail
creativefull 54b70a4
Merge pull request #1 from creativefull/master
dirkjanm 99af818
Change parameter to basePath for external images
dirkjanm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
node_modules | ||
*.log |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
WEBVTT | ||
|
||
00:00:00.000 --> 00:00:05.000 | ||
oceans.jpg#xywh=0,0,120,68 | ||
|
||
00:00:05.000 --> 00:00:10.000 | ||
oceans.jpg#xywh=120,0,120,68 | ||
|
||
00:00:10.000 --> 00:00:15.000 | ||
oceans.jpg#xywh=240,0,120,68 | ||
|
||
00:00:15.000 --> 00:00:20.000 | ||
oceans.jpg#xywh=360,0,120,68 | ||
|
||
00:00:20.000 --> 00:00:25.000 | ||
oceans.jpg#xywh=480,0,120,68 | ||
|
||
00:00:25.000 --> 00:00:30.000 | ||
oceans.jpg#xywh=600,0,120,68 | ||
|
||
00:00:30.000 --> 00:00:35.000 | ||
oceans.jpg#xywh=720,0,120,68 | ||
|
||
00:00:35.000 --> 00:00:40.000 | ||
oceans.jpg#xywh=840,0,120,68 | ||
|
||
00:00:40.000 --> 00:00:45.000 | ||
oceans.jpg#xywh=960,0,120,68 | ||
|
||
00:00:45.000 --> 00:00:50.000 | ||
oceans.jpg#xywh=1080,0,120,68 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
{ | ||
"name": "videojs-thumbnails", | ||
"description": "progress bar thumbnails plugin for video.js", | ||
"version": "0.1.1", | ||
"version": "1.0.0", | ||
"peerDependencies": { | ||
"video.js": "^4.0" | ||
}, | ||
"devDependencies": { | ||
"grunt": "^0.4.4", | ||
"grunt-contrib-connect": "^0.9.0", | ||
"grunt-contrib-jshint": "^0.10.0", | ||
"video.js": "4.10.1" | ||
"video.js": "4.12.4" | ||
} | ||
} |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of the edge cases are much cleaner. Nice!