Don't check picard.jar in to lib, but instead declare as dependency i… #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n gradle. I'm checking this for posterity, but I won't merge because until broadinstitute/picard#1919 is merged and we upgrade to a version including this change, we need to declare all the transitive dependencies we use in our code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #364 +/- ##
=========================================
Coverage 81.02% 81.02%
Complexity 4200 4200
=========================================
Files 315 315
Lines 17696 17696
Branches 2760 2760
=========================================
Hits 14339 14339
Misses 2249 2249
Partials 1108 1108 ☔ View full report in Codecov by Sentry. |
|
@alecw: Does broadinstitute/picard#1934 change anything compared to last year? I have no clue how Gradle work but figured you might have missed this. |
|
Hi @mschilli87, This change causes some problems downstream for us building some tools that depend on dropseq.jar. Since the current arrangement is working, it hasn't been a priority for us to debug it. -Alec |
|
I believe the changes in this PR have been completed via #373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n gradle.
I'm checking this for posterity, but I won't merge because until broadinstitute/picard#1919 is merged and we upgrade to a version including this change, we need to declare all the transitive dependencies we use in our code.
Saving these changes for posterity but probably not going to merge, because having to enumerate many transitive dependencies is ugly. Also, there are some (e.g. freemarker) where it probably would be better to change the code rather than pull in a jar for a single utility method.