Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory footprint by quasi-interning allowed barcodes #428

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

alecw
Copy link
Collaborator

@alecw alecw commented Jun 10, 2024

No description provided.

@alecw alecw requested a review from kshakir June 10, 2024 15:17
Copy link
Contributor

@kshakir kshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the JVM/caching tricks going on here within StringInterner but I don't think this will have a negative impact so: LGTM

@alecw alecw merged commit 51d68e8 into master Jun 10, 2024
4 checks passed
@alecw alecw deleted the aw_intern_barcodes branch June 10, 2024 15:33
@kshakir
Copy link
Contributor

kshakir commented Jun 10, 2024

Note to my future self: Multiple instances of Strings will still be equal to each other. Thus for each candidate equal to an existing key in the map, the existing quasi-interned value will be returned instead of the original candidate. Neat.

I am not familiar with the JVM/caching tricks going on here within StringInterner but I don't think this will have a negative impact so: LGTM

Note to my future self: Multiple instances of Strings will still be equal to each other. Thus for each candidate equal to an existing key in the map, the existing quasi-interned value will be returned instead of the original candidate. Neat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants