Fix for donor assignment negative infinity likelihoods. #477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for edge case bug where multiple reads are summarized as a single UMI with a single phred score. Due to the underlying error rating being quantized by the pred score, a very high error rate of 0.9 or higher is quantized to a phred score of 0. This is equivalent to an error rate of 1 when the phred score is unpacked to a probability, which causes errors with the downstream likelihoods.
To fix this, during summarization, if the phred score is less than 1 it is set to 1. This avoids issues in the likelihood calculations where having probabilities of 0 causes issues when logged (plus probabilities should always include some uncertainty, which is lost if a phred score is 0.)