-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jn compare bam tag values #487
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now passes existing unit tests that use it. It needs its own set of unit tests to validate that the outputs look good, but the basic processing/comparisons of two BAM files looks solid.
…ingle read bam could flip the tag values in the output file so the tags were associated with the wrong data set.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #487 +/- ##
============================================
+ Coverage 80.69% 80.76% +0.07%
- Complexity 4702 4812 +110
============================================
Files 358 363 +5
Lines 20045 20514 +469
Branches 3125 3213 +88
============================================
+ Hits 16175 16569 +394
- Misses 2607 2641 +34
- Partials 1263 1304 +41 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greatly enhanced CompareBAMTagValues to support analysis where BAM files are inexact - tool now emits reads that are discordant between two data sets, reads that are unique to a data set, and a metrics file that contains the tag values in each data set - either for all tag values, or those that are discordant.