Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid long argument lists #127

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Avoid long argument lists #127

merged 3 commits into from
Feb 21, 2024

Conversation

jchadwick-buf
Copy link
Member

If the list of Go files exceeds 128 KiB, the gofmtmodtidy and checknonolint rules might fail due to long argument lists.

@jchadwick-buf jchadwick-buf requested a review from bufdev February 21, 2024 18:51
@jchadwick-buf
Copy link
Member Author

jchadwick-buf commented Feb 21, 2024 •
edited
Loading

Actually, I'm not really sure that that if actually works as intended.

Yeah, not really. Better solution using grep with the -r and --include options which are apparently portable (checked macOS/BSD/Linux manpages.)

pkwarren
pkwarren reviewed Feb 21, 2024
View reviewed changes
make/go/go.mk Outdated Show resolved Hide resolved
@jchadwick-buf jchadwick-buf changed the title Use xargs to avoid long argument lists Avoid long argument lists Feb 21, 2024
pkwarren
pkwarren reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@pkwarren pkwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@jchadwick-buf
Copy link
Member Author

Merging for now since it's breaking stuff. We can follow up later if it's not good enough.

@jchadwick-buf jchadwick-buf merged commit b2b0b45 into main Feb 21, 2024
4 checks passed
@jchadwick-buf jchadwick-buf deleted the jchadwick/arg-too-long branch February 21, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkwarren pkwarren pkwarren approved these changes

@bufdev bufdev Awaiting requested review from bufdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchadwick-buf @pkwarren