Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid long argument lists #127

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Avoid long argument lists #127

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0974500
Use xargs to avoid long argument lists
jchadwick-buf Feb 21, 2024
31fe6da
Fix checknonolint using grep --include
jchadwick-buf Feb 21, 2024
8cc225e
Use `gofmt .` instead of using `find` for formatting
jchadwick-buf Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions make/go/go.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,14 @@ godeps: deps
.PHONY: gofmtmodtidy
gofmtmodtidy:
@echo gofmt -s -w ALL_GO_FILES
@gofmt -s -w $(shell find . -name '*.go')
@find . -name '*.go' -print0 | xargs -0 gofmt -s -w
jchadwick-buf marked this conversation as resolved.
Show resolved Hide resolved
go mod tidy -v

format:: gofmtmodtidy

.PHONY: checknonolint
checknonolint:
@if grep '//nolint' $(shell find . -name '*.go'); then \
@if grep -r --include "*.go" '//nolint'; then \
echo '//nolint directives found, surface ignores in .golangci.yml instead' >&2; \
exit 1; \
fi
Expand Down
Loading