Update protoc to v29.1 and protoc-gen-go to v1.36.0 #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkwarren
reviewed
Dec 17, 2024
| # NOTE: Set to version compatible with genproto source code (only used in tests). | ||
| PROTOC_VERSION ?= 27.0 | ||
| PROTOC_VERSION ?= 29.1 |
There was a problem hiding this comment.
Do we also want to update protoc_gen_go.mk while we're here?
There was a problem hiding this comment.
Yep, this seems reasonable, added protoc-gen-go also :)
doriable
changed the title
pkwarren
approved these changes
Dec 17, 2024
mfridman
approved these changes
Dec 17, 2024
mfridman
reviewed
Dec 17, 2024
| # NOTE: Set to version compatible with genproto source code (only used in tests). | ||
| PROTOC_VERSION ?= 27.0 | ||
| PROTOC_VERSION ?= 29.1 |
There was a problem hiding this comment.
Did we need to update the script to include any additional files?
There was a problem hiding this comment.
It is included as part of include/google, I checked by manually testing and upgrade to bufbuild/buf and running make generate.
There was a problem hiding this comment.
Yep, checked as well.
include/google/protobuf
├── any.proto
├── api.proto
├── compiler
│ └── plugin.proto
├── cpp_features.proto
├── descriptor.proto
├── duration.proto
├── empty.proto
├── field_mask.proto
├── go_features.proto
├── java_features.proto
├── source_context.proto
├── struct.proto
├── timestamp.proto
├── type.proto
└── wrappers.proto
2 directories, 15 files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.