Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protoc to v29.1 and protoc-gen-go to v1.36.0 #175

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Update protoc to v29.1 and protoc-gen-go to v1.36.0 #175

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51b192e
Update protoc to v29.1
doriable Dec 17, 2024
e942da9
Add `protoc-gen-go` to update
doriable Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions make/go/dep_protoc.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ $(call _assert_var,CACHE_INCLUDE)
$(call _assert_var,CACHE_BIN)

# Settable
# https://github.com/protocolbuffers/protobuf/releases 20240523 checked 20240527
# https://github.com/protocolbuffers/protobuf/releases 20241204 checked 20241217
# NOTE: Set to version compatible with genproto source code (only used in tests).
PROTOC_VERSION ?= 27.0
PROTOC_VERSION ?= 29.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to update protoc_gen_go.mk while we're here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this seems reasonable, added protoc-gen-go also :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we need to update the script to include any additional files?

https://github.com/bufbuild/makego/blob/e7d3bb3f61509411ebfae10283b677b304f04c72/make/go/dep_protoc.mk/#L47

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is included as part of include/google, I checked by manually testing and upgrade to bufbuild/buf and running make generate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, checked as well.

include/google/protobuf
├── any.proto
├── api.proto
├── compiler
│   └── plugin.proto
├── cpp_features.proto
├── descriptor.proto
├── duration.proto
├── empty.proto
├── field_mask.proto
├── go_features.proto
├── java_features.proto
├── source_context.proto
├── struct.proto
├── timestamp.proto
├── type.proto
└── wrappers.proto

2 directories, 15 files


# Google adds a dash to release candidate versions in the name of the
# release artifact, i.e. v27.0-rc1 -> v27.0-rc-1
Expand Down
Loading