feat(NovoDataTablePagination): Add option to show the total number of… #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… records in a table next to pagination
|
Visit the preview URL for this PR (updated for commit 43a72ca): https://novo-elements--pr1648-f-show-pagination-to-yjvonoaf.web.app (expires Thu, 06 Feb 2025 19:01:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f1783e19c2444272095017dd8ba433fff0ee3f61 |
…ion when in footer
dvoegelin
previously approved these changes
Jan 29, 2025
davidkbh
approved these changes
Jan 31, 2025
dvoegelin
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… records in a table next to pagination
Description
Added an option on Novo Data Tables pagination to include a total records next to the Items per Page dropdown. Set it to true when pagination is in footer
Verify that...
npm startandnpm run buildstill worksSafari,ChromeandFirefoxnpm run lintpassesnpm testpasses and code coverage is increasednpm run buildstill worksBullhorn Internal Developers
Novo AutomationScreenshots