Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integer-based std_pow #399

Merged
merged 15 commits into from
Feb 20, 2021
Merged

Add integer-based std_pow #399

merged 15 commits into from
Feb 20, 2021

Conversation

cgyurgyik
Copy link
Collaborator

No description provided.

@cgyurgyik
Copy link
Collaborator Author

cgyurgyik commented Feb 10, 2021 •
edited
Loading

@rachitnigam Should this be moved to unsigned? Eventually I'll need to implement another for fixed point.

However, that's also essentially the case for std_sqrt, and any math operation where sign vs unsigned vs fixed point makes a difference, which means you might have something else in mind.

@cgyurgyik cgyurgyik mentioned this pull request Feb 15, 2021
Merged
@cgyurgyik
Copy link
Collaborator Author

This should probably be re-named to std_pow to follow classic naming convention.

@cgyurgyik cgyurgyik changed the title Add integer-based std_exp Add integer-based std_pow Feb 19, 2021
@rachitnigam
Copy link
Contributor

LGTM, merge whenever you're ready.

@cgyurgyik cgyurgyik merged commit 03fa032 into master Feb 20, 2021
@cgyurgyik cgyurgyik deleted the std_exp branch February 20, 2021 16:43
@cgyurgyik
Copy link
Collaborator Author

I also failed to mention that that the actual component was essentially pulled from @rachitnigam's Invoke PR, #300.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachitnigam rachitnigam rachitnigam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgyurgyik @rachitnigam