-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WD-7913] support portal legal pages #13426
[WD-7913] support portal legal pages #13426
Conversation
Demo starting at https://ubuntu-com-13426.demos.haus |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13426 +/- ##
=======================================
Coverage 74.41% 74.41%
=======================================
Files 107 107
Lines 2838 2838
Branches 946 946
=======================================
Hits 2112 2112
Misses 702 702
Partials 24 24 |
For https://ubuntu-com-13426.demos.haus/legal/data-privacy/support-portal
For https://ubuntu-com-13426.demos.haus/legal/terms-and-policies/support-portal
|
@Sophie-32 Thanks for having a look. Your suggestions make total sense, however these 2 new pages are implemented in accordance to every other similar page under /legal/data-privacy and /legal/terms-and-policies. If we are to change the new ones, I believe we need to change all the other existing ones the same way. |
Yes that makes sense! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I couldn't compare with the other two copy docs because I didn't have permission to view them. I think you may want to add at least view permissions next time you create a copy doc, or maybe it's a folder issue.
Done
QA
./run serve
ordotrun
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-7913
Help
QA steps - Commit guidelines