-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy parser #37
Lazy parser #37
Conversation
Not clear to me whether the failed job (stack 8.2.2) is due to the laziness test or if it just happened to time out. |
Figured out how to rerun the job. Looks like it was just bad luck. |
Thanks again for implementing this! The code looks great. Also thanks for investigating the travis job. You want to go ahead and remove the containers and parsec dependencies, update the version number, and make a release? (If not, no problem, I can always do it.) I don't think this PR changes the types of any user-facing functions, so we could probably just update the minor version number. However, this lazy functionality is really great, and a big change to pretty-simple, so I'd even be fine with making the version something like 3.0.0.0. (I'd also like to make a blog post introducing this new version of pretty-simple, so it would sound better if it was bumped to 3.0.0.0, however this is a bad reason to decide the version of a library!) |
Also, this is from #9 (comment):
Did you want to create a new issue about this? Unless you're planning on doing this right away, it might help someone else looking to implement this. |
OK. I have bumped the version number to 2.2.0.0 and updated the changelog. I will open up that comment as another issue and I will merge as soon as Travis has finished. |
OK, I managed to upload it to Hackage. The documentation isn't appearing, though, but I'm assuming that it takes a moment to generate? |
@andrew-lei Thanks a lot for uploading this to Hackage! The documentation usually takes a while to appear. It looks like has been created: http://hackage.haskell.org/package/pretty-simple Also, in the future, when you make a release, would you be able to create a tag and push it to github? I'll go ahead and run the following commands at the current master branch: $ git tag v2.2.0.0 -m 'release version 2.2.0.0'
$ git push --tag |
Closes #9.