fix returned type from get_token_from_bearer #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CGarces-Apser <[email protected]>
Sambigeara
reviewed
Apr 15, 2024
| @@ -58,9 +58,8 @@ def verify_jwt(credentials: Credentials) -> bool: | |||
|
|
|||
|
|
|||
| async def get_token_from_bearer( | |||
| request: Request, | |||
There was a problem hiding this comment.
The purpose of this was just to demonstrate that request is available in the dependable function. We could change to an unnamed var? E.g. _: Request
| http_credentials: HTTPAuthorizationCredentials = Depends(bearer_scheme), | ||
| ) -> Credentials: | ||
| ) -> str: |
There was a problem hiding this comment.
I think we'd have to either specify an Optional[str], or perhaps more correctly; return an empty string in the case when http_credentials does not resolve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return type of get_token_from_bearer should be str, also the request parameter is not used.
Checklist
git commit -s ...) to provide the DCO