Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix returned type from get_token_from_bearer #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −2
Open

fix returned type from get_token_from_bearer #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,8 @@ def verify_jwt(credentials: Credentials) -> bool:


async def get_token_from_bearer(
request: Request,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this was just to demonstrate that request is available in the dependable function. We could change to an unnamed var? E.g. _: Request

http_credentials: HTTPAuthorizationCredentials = Depends(bearer_scheme),
) -> Credentials:
) -> str:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd have to either specify an Optional[str], or perhaps more correctly; return an empty string in the case when http_credentials does not resolve.

if http_credentials:
if not http_credentials.scheme == "Bearer":
raise HTTPException(
Expand Down