-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Rust frontend proptest for collection operations against SQLite impl #3814
Open
codetheweb
wants to merge
1
commit into
feat-in-memory-frontend
Choose a base branch
from
feat-rust-frontend-proptest
base: feat-in-memory-frontend
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,668
−151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
7e087f8
to
e8aee9a
Compare
85b22da
to
9c0bb95
Compare
e8aee9a
to
25c8518
Compare
9c0bb95
to
9f52e57
Compare
25c8518
to
256940a
Compare
9f52e57
to
0142a9c
Compare
256940a
to
01f72a0
Compare
1 task
0142a9c
to
5cfc254
Compare
01f72a0
to
a751c89
Compare
5cfc254
to
0e896c9
Compare
a751c89
to
ef63c70
Compare
ef63c70
to
25da282
Compare
1 task
c0c65cf
to
bd5e73e
Compare
1d59d07
to
ee35e1f
Compare
bd5e73e
to
01bf625
Compare
ee35e1f
to
b0c6dd0
Compare
cff87c2
to
471004f
Compare
b0c6dd0
to
db72c7c
Compare
59e8d53
to
dbb39bb
Compare
dbb39bb
to
1431bd2
Compare
12507d1
to
61f0604
Compare
db72c7c
to
23f31bd
Compare
61f0604
to
8fbb90d
Compare
codetheweb
added a commit
that referenced
this pull request
Mar 7, 2025
## Description of changes Found this bug while working on #3814. ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust Added test was previously failing. ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?* n/a
23f31bd
to
7b62478
Compare
8fbb90d
to
597dd89
Compare
7b62478
to
c0a6303
Compare
597dd89
to
43b6fed
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a Rust proptest for collection operations against the SQLite implementation. Follow up work includes:
The proptest outputs stats about generated query selectivity after running as naive generation of requests for
.get()
will usually result in selecting all or no records. Example output:Note that 23% of queries returned only part of the collection when filtering with a where clause. This doesn't sound super high, but it started at 3-4% before I fixed filter generation to bias towards known values. We can make this higher if we want by tweaking a few parameters.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a