[ENH]: add in-memory frontend impl #3902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This was referenced Mar 4, 2025
Sicheng-Pan
reviewed
Mar 4, 2025
Sicheng-Pan
reviewed
Mar 4, 2025
| .map(|(_, v)| v.clone()) | ||
| .collect::<Vec<_>>(); | ||
|
|
||
| struct RecordWithDistance(f32, ProjectionRecord); |
There was a problem hiding this comment.
nit: maybe use this
chroma/rust/types/src/execution/operator.rs
Line 457 in a89837f
There was a problem hiding this comment.
KnnProjectionRecord doesn't implement Ord
Sicheng-Pan
reviewed
Mar 4, 2025
codetheweb
force-pushed
the
feat-in-memory-frontend
branch
from
a979491 to
ae729a3
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
codetheweb
force-pushed
the
feat-in-memory-frontend
branch
2 times, most recently
from
781c521 to
1d59d07
Compare
Sicheng-Pan
reviewed
Mar 6, 2025
Comment on lines
+24
to
+25
| tenants: HashSet<String>, | ||
| databases: Vec<Database>, |
There was a problem hiding this comment.
nit: HashMap<String, Vec<Database>> that maps tenant to databases might be cleaner
There was a problem hiding this comment.
🤷 we usually filter by some combination of the tenant and database names
given that we expect < 1k databases during testing I think this is fine for now
I can optimize later if a flamegraph says it's slow
codetheweb
force-pushed
the
feat-in-memory-frontend
branch
4 times, most recently
from
db72c7c to
23f31bd
Compare
codetheweb
force-pushed
the
feat-in-memory-frontend
branch
from
23f31bd to
7b62478
Compare
codetheweb
force-pushed
the
feat-in-memory-frontend
branch
from
7b62478 to
c0a6303
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds an in-memory frontend implementation to be used for testing. Makes the
Frontendtype an enum to do enum dispatch over.Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustAdded a test for the new frontend impl.
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
n/a