render link to cabinet details as menu button #78
Conversation
|
@dianamartin @ChrispinP this only change is at the bottom of the file. |
johnclary
changed the title
| @@ -873,3 +912,16 @@ $(document).on("knack-view-render.view_1252", function (event, page) { | |||
| //////////////////////////////////////////// | |||
| /// End Technician Time Log Validation /// | |||
| //////////////////////////////////////////// | |||
|
|
|||
| //// Update link text to cabinet details page from signal detals | |||
There was a problem hiding this comment.
Instead of JS, use this Trigger Button article styling the button with CSS and calling it with the HTML whenever you need it.
There was a problem hiding this comment.
ah, that's a cool trick! TIL. those docs are excellent!
in this case i'm styling a details link from a connection field, so i don't have control in the builder over what html is rendered by Knack. without this custom code, the link text would simply be the display field on the cabinets record.
for the CSS, i'm just using the same classes that knack uses on their menu buttons. that actually might be a nice improvement in your docs. you might not need to write any custom CSS if you can get by with the knack classes.
| }); | ||
| $coacdButton.appendTo("#" + viewId); | ||
|
|
||
| // Append Big SSO Login button and non-SSO Login button | ||
| bigButton("coacd-big-button", "coacd-button-login", url, "sign-in", "Sign-In") | ||
| bigButton( |
There was a problem hiding this comment.
Curious on the reasoning of re-expanding the SSO code to take up more lines?
There was a problem hiding this comment.
this is the default formatting behavior of Prettier. i actually was surprised it picked up more linting, since i linted this code the last time i edited it a few months ago. it makes me wonder if knack does some kind of linting automatically, or if my linter settings changed somehow.
i'm happy to defer to the linter's opinions, which aim for more readable code over being concise. in the past we've talked about standardizing these settings and making sure we use them globally, basically the standard right now it prettier's default.
| startField, | ||
| endField | ||
| )}`; | ||
| errorMsgs = `${errorMsgs}${formatErrorMessage(startField, endField)}`; |
| formDiv, | ||
| errorMsgs | ||
| ); | ||
| // show red error banner |
|
@johnclary this ready to merge? |
|
@johnclary ping |
Related to cityofaustin/atd-data-tech#8032. Renders the cabinet details link as a menu button (instead of the cabinet ID)