Set profile greeting fields based on actual contact type

[colemanw]

Overview

Fixes civicrm/org.civicrm.contactlayout#58
Sets greeting options in a profile based on the actual contact type being edited, if applicable.

Before

Contact type was determined based on the profile type, even when editing an existing contact.

After

When editing an existing contact, contact type is determined from that contact.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

So are we confident the form id would always be the contact id here?

[ryanlrobinson]

Works in my test, the same scenario that prompted filing the issue.

[colemanw]

@eileenmcnaughton err, no I'm not confident of that. In fact, I notice that there is a $contactId param that should be getting passed to this function, but is not. And (maddeningly) in other contexts values are being passed to that param like activity_id, contribution_id etc. So we can't rely on that!

[colemanw]

Ok I've checked some more. This function is really screwy. We can't use the $contactId param because that's actually used for setting the field id. So second best is to kind of hack it in like this. I've updated the PR to only act when the profile is of type "Contact" which should be safer.

[eileenmcnaughton]

OK - I feel like I would probably extract the 'inids' of this function (below the part where $name is determined) and create a sub-function called buildNamedProfile & we could probably restore sanity here.

I did find some reasons to give me enough comfort to merge this though

1. Later in the external_identifier part I see a clear assumption that $form->get('id') would be the contact ID

      $form->add('text', $name, $title, $attributes, $required);
      $contID = $contactId;
      if (!$contID) {
        $contID = $form->get('id');
      }
      $form->addRule($name,
        ts('External ID already exists in Database.'),
        'objectExists',
        array('CRM_Contact_DAO_Contact', $contID, 'external_identifier')
      );
    }

2. On reflection this parameter is ONLY used for the greeting types so the risk is fairly contained.

3. this needs cleaning up but step one is probably just to reformat the file otherwise it's gonna be a pain

[eileenmcnaughton]

This feels like a VERY small step on our general expectation that we should do some cleanup when touching toxic functions - #14853 but it does remove something that was blocking more cleanup