chore: Changes hotspot click area to 24 pxs #3237
Closed
+71
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increases the hotspot button size to 24x24 according to WCAG2.2 guidelines.
Reviewer notes
Increasing the button size would change the occupying space the button. Also it increases the space between the icon (16x16) and the popover that appears next to it. To avoid visual change:
ref
moved to the icon. Previously it was on the button.<div />
whoseref
we use for the popover positioning.<Hotspot />
) rather than the button itself (<AnnotationTrigger />
) to match the previous visuals.Related links, issue #, if available: AWSUI-60217
How has this been tested?
Dev pipeline visual tests.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.