Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Changes hotspot click area to 24 pxs #3237

Closed

Conversation

orangevolon
Copy link
Contributor

@orangevolon orangevolon commented Jan 30, 2025

Description

Increases the hotspot button size to 24x24 according to WCAG2.2 guidelines.

Reviewer notes

Increasing the button size would change the occupying space the button. Also it increases the space between the icon (16x16) and the popover that appears next to it. To avoid visual change:

  • The popover tracking ref moved to the icon. Previously it was on the button.
  • Icon is now wrapper into a <div /> whose ref we use for the popover positioning.
  • We changed the positioning in the use case (<Hotspot />) rather than the button itself (<AnnotationTrigger />) to match the previous visuals.

Related links, issue #, if available: AWSUI-60217

How has this been tested?

Dev pipeline visual tests.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (c1a6f63) to head (f51b747).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3237   +/-   ##
=======================================
  Coverage   96.45%   96.45%           
=======================================
  Files         790      790           
  Lines       22294    22294           
  Branches     7667     7599   -68     
=======================================
  Hits        21504    21504           
  Misses        738      738           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orangevolon orangevolon force-pushed the alamiami/changes-hotspot-click-area-to-24-pxs branch from 6478ec5 to fa7195d Compare January 31, 2025 11:02
@orangevolon orangevolon changed the title Alamiami/changes hotspot click area to 24 pxs chore: Changes hotspot click area to 24 pxs Jan 31, 2025
@orangevolon
Copy link
Contributor Author

Closing in favor of the simpler option #3246

@orangevolon orangevolon closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant