[CCAP-567] - Refactor address validation flow for parentHome, parentMailing, providerResponseService, providerMailing addresses #1236

analoo · 2025-03-03T19:00:25Z

🔗 Jira ticket

CCAP-567

✍️ Description

Family Flow |

Home address is validated if the inputted address and the suggested address are not the same.
Mailing address is validated when different than the home address if the inputted address and the suggested address are not the same.

Provider Flow

Service address should be validated if the inputted address and the suggested address are not the same.
Mailing address should be validated when different than the service address if the inputted address and the suggested address are not the same.
Once a user validates an address, the inputted address will be updated to equal the validated value.
Code logic no longer references _validated address fields
If first and second addresses are the same, then only the first one will appear in the PDF.

Screens match designs
refactors (confirmed address flows) to reduce code complexity
adds tests for address validation

📷 Design reference

✅ Completion tasks

Added relevant tests
Meets acceptance criteria

src/main/java/org/ilgcc/app/utils/AddressUtilities.java

src/main/java/org/ilgcc/app/inputs/Gcc.java

src/main/java/org/ilgcc/app/submission/actions/SaveValidatedAddress.java

src/main/java/org/ilgcc/app/utils/AddressUtilities.java

analoo · 2025-03-04T00:41:59Z

src/main/java/org/ilgcc/app/submission/actions/SetOrganizationIdAndCCRRName.java

@@ -28,22 +28,20 @@ public class SetOrganizationIdAndCCRRName implements Action {
    CCMSDataServiceImpl ccmsDataServiceImpl;

    private static final String ORGANIZATION_ID_INPUT = "organizationId";
-    private static final String UNVALIDATED_ZIPCODE_INPUT_NAME = "parentHomeZipCode";


renamed because the same input will hold validated and unvalidated zip code data.

src/main/java/org/ilgcc/app/submission/actions/SaveValidatedAddress.java

analoo · 2025-03-06T23:59:12Z

src/main/resources/flows-config.yaml

@@ -641,7 +651,8 @@ flow:
    nextScreens:
      - name: registration-confirm-mailing-address
  registration-confirm-mailing-address:
-    condition: EnableProviderRegistration
+    condition: ShowProviderResponseMailingAddressConfirmationScreen


We can incorporate Enable Provider Registration into the condition but you can't come to this place any reasonable way

Agreed, not a big deal.

src/main/resources/flows-config.yaml

…addresses being confirmed

…p confirmation screen when addresses pretty much match

…ymore and update isHomelessMethod to accept input name

…ces of truth for address.

…es that the applicant confirmed

…ailing

…pplication

…s tested elsewhere

…ts, rename test for accuracy

cram-cfa

LGTM. Thanks for those changes!

src/main/java/org/ilgcc/app/submission/conditions/ShowAddressConfirmationScreen.java

analoo added Open to feedback This PR isn't ready to be merged into `main` but feedback is welcome Work in Progress labels Mar 3, 2025

github-actions bot assigned analoo Mar 3, 2025

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 3, 2025 19:01 Inactive

github-advanced-security bot found potential problems Mar 3, 2025

View reviewed changes

cram-cfa reviewed Mar 3, 2025

View reviewed changes

src/main/java/org/ilgcc/app/inputs/Gcc.java Show resolved Hide resolved

cram-cfa reviewed Mar 3, 2025

View reviewed changes

src/main/java/org/ilgcc/app/submission/actions/SaveValidatedAddress.java Outdated Show resolved Hide resolved

cram-cfa reviewed Mar 3, 2025

View reviewed changes

src/main/java/org/ilgcc/app/utils/AddressUtilities.java Outdated Show resolved Hide resolved

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 4, 2025 00:02 Inactive

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 4, 2025 00:27 Inactive

analoo changed the title ~~Ccap 567 validate home address~~ [CCAP-567] - validate home address Mar 4, 2025

analoo commented Mar 4, 2025

View reviewed changes

src/main/java/org/ilgcc/app/utils/AddressUtilities.java Outdated Show resolved Hide resolved

analoo commented Mar 4, 2025

View reviewed changes

src/main/java/org/ilgcc/app/utils/AddressUtilities.java Outdated Show resolved Hide resolved

analoo commented Mar 4, 2025

View reviewed changes

analoo commented Mar 5, 2025

View reviewed changes

src/main/java/org/ilgcc/app/submission/actions/SaveValidatedAddress.java Outdated Show resolved Hide resolved

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 5, 2025 20:06 Inactive

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 5, 2025 23:26 Inactive

analoo force-pushed the CCAP-567-validate-home-address branch from 6fe45b6 to 8241a4b Compare March 6, 2025 16:59

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 6, 2025 16:59 Inactive

analoo force-pushed the CCAP-567-validate-home-address branch from 8241a4b to 7cf68fa Compare March 6, 2025 21:32

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 6, 2025 21:32 Inactive

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 6, 2025 21:37 Inactive

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 6, 2025 23:56 Inactive

analoo commented Mar 6, 2025

View reviewed changes

src/main/resources/flows-config.yaml Outdated Show resolved Hide resolved

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 7, 2025 18:51 Inactive

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 7, 2025 18:56 Inactive

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 7, 2025 19:50 Inactive

analoo removed Open to feedback This PR isn't ready to be merged into `main` but feedback is welcome Work in Progress labels Mar 7, 2025

analoo added 20 commits March 7, 2025 13:43

[CCAP-567] - create a new Address Utility and move address logic into it

2dc074f

templatize address screen for parent-home-address

68c2060

rename parent-confirm-address to reduce ambiguity between two parent …

2d8511a

…addresses being confirmed

[CCAP-567] - Implements confirm-parent-home-address screen

24fa30f

[CCAP-567] - Save Validated home address back to home address and ski…

17915d1

…p confirmation screen when addresses pretty much match

Rename unvalidated zip code to reflect that there is no such thing an…

c783360

…ymore and update isHomelessMethod to accept input name

Use new templates and logic for parent mailing address

032de8e

Remove Mailing address preparers which relied on there being two sour…

cb0c429

…ces of truth for address.

Update the parent-info-review screen to correctly reflect the address…

e45bdfc

…es that the applicant confirmed

Scaffolds tests to be added in Address Journey

cfcc96c

Journey tests for address confirmation in family flow

98e0b78

[CCAP-567] - tests address validation

1e6fcca

Cleans up formatting and labels addressGroupInputPrefix accurately

592999e

Implement new mailing logic for providerResponseService and providerM…

e91f1f6

…ailing

Fix failing tests in provider flow

c971bb0

rename confirm-address to confirm-service-address

625aa9d

If mailing address matches service or home address, leave it out of a…

1efb293

…pplication

These tests feel like overkill

a59b971

Keeps only address happy path in journey test since address journey i…

ace14f0

…s tested elsewhere

Respond to Marcs feedback about abstract classes, remove outdated tes…

e8fbdfa

…ts, rename test for accuracy

enyia21 temporarily deployed to il-gcc-ccap-567-validat-up9pmw March 7, 2025 21:43 Inactive

analoo force-pushed the CCAP-567-validate-home-address branch from 7bdd211 to e8fbdfa Compare March 7, 2025 21:44

enyia21 deployed to il-gcc-ccap-567-validat-up9pmw March 7, 2025 21:45 View deployment

analoo added the Ready For Review label Mar 7, 2025

analoo requested a review from cram-cfa March 7, 2025 21:52

cram-cfa approved these changes Mar 7, 2025

View reviewed changes

analoo changed the title ~~[CCAP-567] - validate home address~~ [CCAP-567] - Refactor address validation flow for parentHome, parentMailing, providerResponseService, providerMailing addresses Mar 8, 2025

analoo added Ready to Merge and removed Ready For Review labels Mar 8, 2025

mtodd-cfa approved these changes Mar 8, 2025

View reviewed changes

src/main/java/org/ilgcc/app/submission/conditions/ShowAddressConfirmationScreen.java Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CCAP-567] - Refactor address validation flow for parentHome, parentMailing, providerResponseService, providerMailing addresses #1236

[CCAP-567] - Refactor address validation flow for parentHome, parentMailing, providerResponseService, providerMailing addresses #1236

analoo commented Mar 3, 2025 •

edited

Loading

analoo Mar 4, 2025

analoo Mar 6, 2025

cram-cfa Mar 7, 2025

cram-cfa left a comment

[CCAP-567] - Refactor address validation flow for parentHome, parentMailing, providerResponseService, providerMailing addresses #1236

Are you sure you want to change the base?

[CCAP-567] - Refactor address validation flow for parentHome, parentMailing, providerResponseService, providerMailing addresses #1236

Conversation

analoo commented Mar 3, 2025 • edited Loading

🔗 Jira ticket

✍️ Description

📷 Design reference

✅ Completion tasks

analoo Mar 4, 2025

Choose a reason for hiding this comment

analoo Mar 6, 2025

Choose a reason for hiding this comment

cram-cfa Mar 7, 2025

Choose a reason for hiding this comment

cram-cfa left a comment

Choose a reason for hiding this comment

analoo commented Mar 3, 2025 •

edited

Loading