Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCAP-567] - Refactor address validation flow for parentHome, parentMailing, providerResponseService, providerMailing addresses #1236
base: main
Are you sure you want to change the base?
[CCAP-567] - Refactor address validation flow for parentHome, parentMailing, providerResponseService, providerMailing addresses #1236
Changes from all commits
2dc074f
68c2060
2d8511a
24fa30f
17915d1
c783360
032de8e
cb0c429
e45bdfc
cfcc96c
98e0b78
1e6fcca
592999e
e91f1f6
c971bb0
625aa9d
1efb293
a59b971
ace14f0
e8fbdfa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates the input name to be in a standard format: https://docs.google.com/spreadsheets/d/1HTZKQnu7dtTPVPnetwvGoFxPzbxl0iSek7j1a9x5ci8/edit?gid=0#gid=0
This standard naming convention makes it possible to templatetize a lot of the address input and confirmation process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PDF content says (Only include mailing address if different from above)

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic overrides the mapped values for these fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I feel like Carl mentioned this as a bug somewhere, not sure if it got filed or just was in the context of "things that are kind of wrong for addresses"
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are NOT using the same address, it maps the mailing address fields

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously getAddress was checking for validated data and we no longer have to do that so we can map directly with the input field names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love to see code deleted! ❤️
This file was deleted.