WIP: 2021 04 06 swoopstyle mycvjr2 #290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marianzburlea
requested changes
Apr 7, 2021
| @@ -0,0 +1,14 @@ | |||
| .section-title Welcome to My CV | |||
There was a problem hiding this comment.
I am pretty sure you don't want the button inside the section-title element
| @@ -0,0 +1,22 @@ | |||
| doctype | |||
There was a problem hiding this comment.
doctype html, you forgot to tell the browser what kind of doctype it is
| html | ||
| head | ||
| title adding some content for the website | ||
| link(rel="stylesheet", href = "style.css") |
There was a problem hiding this comment.
remove extra spaces from link(rel="stylesheet", href = "style.css")
to link(rel="stylesheet", href="style.css")
| link(rel="stylesheet", href = "style.css") | ||
| body | ||
| .content | ||
| .section-title Welcome to My CV |
There was a problem hiding this comment.
too much indentation, .section-title should be the child of .contentat the same level as button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.