Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: 2021 04 06 swoopstyle mycvjr2 #290

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

WIP: 2021 04 06 swoopstyle mycvjr2 #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0a59493
mycvjrupdate
Apr 6, 2021
9af1f45
update
Apr 6, 2021
7c00da0
gulpup
Apr 6, 2021
27e14d5
let's start with the about me section
Apr 6, 2021
bc2785b
update3
Apr 6, 2021
ee3306b
change
Apr 6, 2021
f271ce6
update
Apr 6, 2021
87ce5f7
save
Apr 6, 2021
3083a2f
change
Apr 6, 2021
a75d88b
downloadcv
Apr 6, 2021
5712066
updates
Apr 7, 2021
b473812
layoutup
Apr 7, 2021
8c83a3c
anupd
Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions gulp/pug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@ const pug = ({ gulp, taskTarget, config, plugins, args, browserSync, baseUrl })
}
})
)
.pipe(plugins.notify({
title: 'Pug Starter - CodeTap',
message: 'Converting PUG into beautiful HTML'
}))
// .pipe(plugins.notify({
// title: 'Pug Starter - CodeTap',
// message: 'Converting PUG into beautiful HTML'
// }))
.on('error', function(error) {
browserSync.notify(printError(error), 25000);
reload = false;
Expand Down
14 changes: 14 additions & 0 deletions src/component/about-me.pug
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
.section-title Welcome to My CV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure you don't want the button inside the section-title element

button.disc
i.icon__youtube
span.button-text YT
h1 Margarita Martescu
h2 Junior Software Developer
h3 About Me
.description-box_with-shadow
p Experienced professional with a demonstrated history of working in the tech and international affairs industries. Highly skilled in analytical and problem solving skills, international relations, management and financial accounting.
p Proud supporter of civil rights, social activism, justice, education and equality for all. Strong graduate from UCL and a prospective MBA Candidate.
swoopstyle marked this conversation as resolved.
Show resolved Hide resolved

button.pill
i.icon__download
span.button-text Download CV
6 changes: 6 additions & 0 deletions src/component/layout/layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// quickly reset margin, padding and box sizing to all elements
* {
padding: 0;
margin: 0;
box-sizing: border-box;
}
22 changes: 22 additions & 0 deletions src/index.pug
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
doctype
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doctype html, you forgot to tell the browser what kind of doctype it is

html
head
title adding some content for the website
link(rel="stylesheet", href = "style.css")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra spaces from link(rel="stylesheet", href = "style.css")
to link(rel="stylesheet", href="style.css")

body
.content
.section-title Welcome to My CV
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too much indentation, .section-title should be the child of .contentat the same level as button

button.disc
i.icon__youtube
span.button-text YT
h1 Margarita Martescu
h2 Junior Software Developer
h3 About Me
.description-box_with-shadow
p Experienced professional with a demonstrated history of working in the tech and international affairs industries. Highly skilled in analytical and problem solving skills, international relations, management and financial accounting.
p Proud supporter of civil rights, social activism, justice, education and equality for all. Strong graduate from UCL and a prospective MBA Candidate.

button.pill
i.icon__download
span.button-text Download CV

1 change: 1 addition & 0 deletions src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
@import '_component/layout/layout'